use overloaded web3 instance instead of single provider. required fo…#76
Conversation
… cycling through multiple public nodes
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
| web3, | ||
| web3Provider: web3.currentProvider, | ||
| web3SubscriptionProvider: web3SubscribAble.currentProvider, |
There was a problem hiding this comment.
The code is directly exposing the web3 and web3Provider objects. This could potentially lead to security issues as it allows direct access to the web3 provider and could be misused. Instead of directly exposing these objects, consider providing a set of methods that abstract the operations that can be performed on these objects. This way, you can control what operations are allowed and how they are performed, which can help to prevent misuse and improve security.
|
|
||
| const web3 = new Web3(eth.web3Provider) | ||
| const web3 = eth.web3 | ||
| const web3Subscriptionable = new Web3(plugins.eth.web3SubscriptionProvider) |
There was a problem hiding this comment.
The code is creating a new instance of Web3 using plugins.eth.web3SubscriptionProvider. However, there is no error handling in case the creation of the new Web3 instance fails. This could lead to unexpected behavior or crashes if the web3SubscriptionProvider is not properly configured or if there are network issues.
To improve this, you should wrap the creation of the new Web3 instance in a try-catch block and handle any potential errors appropriately. This could involve logging the error, retrying the operation, or failing gracefully with a user-friendly error message.
| }) | ||
| } else { | ||
| try { | ||
| result = originalFunctions[key].apply(this, args) | ||
| if (result !== undefined) { | ||
| if (new.target) { | ||
| function F(args) { | ||
| return originalFunction.apply(this, args) | ||
| } | ||
|
|
||
| F.prototype = originalFunction.prototype | ||
|
|
||
| return new F(args) | ||
| } else { | ||
| result = originalFunctions[key].apply(this, args) | ||
| } | ||
|
|
||
| if (typeof result !== "undefined") { | ||
| break | ||
| } |
There was a problem hiding this comment.
The error handling in this code is not sufficient. In the catch block, the error is caught but nothing is done with it. This can make debugging difficult because you lose information about what caused the error.
To improve this, you should at least log the error. Depending on your application's requirements, you might also want to handle specific types of errors differently. For example, you might want to retry on certain types of errors, or report them to an error tracking service.
1 participant
…r cycling through multiple public nodes